actions/setup-python
3
0
Fork 0
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Update contributors.md

Browse Source
This commit is contained in:
Konrad Pabjan 2019-11-07 15:26:27 -05:00 committed by GitHub
parent 2e9d5269cc
commit 2ed535288f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 16 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
docs/contributors.md
View File

@ -3,20 +3,25 @@
### Checkin ### Checkin
- Do checkin source (src) - Do checkin source (src)
- Do checkin build output (lib) - Do checkin a single index.js file after running `ncc`
- Do checkin runtime node_modules - Do not checkin node_modules
- Do not checkin devDependency node_modules (husky can help see below)
### devDependencies ### NCC
In order to handle correctly checking in node_modules without devDependencies, we run [Husky](https://github.com/typicode/husky) before each commit. In order to avoid uploading `node_modules` to the repository, we use [zeit/ncc](https://github.com/zeit/ncc) to create a single `index.js` file that gets saved in `dist/`.
This step ensures that formatting and checkin rules are followed and that devDependencies are excluded. To make sure Husky runs correctly, please use the following workflow:
### Developing
If you're developing locally you can run
``` ```
npm install # installs all devDependencies including Husky npm install
git add abc.ext # Add the files you've changed. This should include files in src, lib, and node_modules (see above) tsc
git commit -m "Informative commit message" # Commit. This will run Husky ncc build
``` ```
An files generated using `tsc` will be added to `lib/` however those files also are not uploaded to the repository and are exluded using `.gitignore`.
During the commit step, Husky will take care of formatting all files with [Prettier](https://github.com/prettier/prettier) as well as pruning out devDependencies using `npm prune --production`. During the commit step, Husky will take care of formatting all files with [Prettier](https://github.com/prettier/prettier)
It will also make sure these changes are appropriately included in your commit (no further work is needed)
### Testing
We ask that you include a link to a succesfull run that utilizes the changes you are working on. For example, if your changes are in the branch `newAwesomeFeature`, then show an example run that uses `setup-python@newAwesomeFeature`. This will help speed up testing and help us confirm that there are no breaking changes or bugs.