actions/setup-node
3
0
Fork 0
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #307 from actions/v-alsvir/disable-cache-usage-temp-v1

Browse Source 
Temporarily disable image cache usage for v1
This commit is contained in:
Alena Sviridenko 2021-08-03 19:21:16 +03:00 committed by GitHub
commit eb416799cf
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 14 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
__tests__/installer.test.ts
View File

@ -88,7 +88,8 @@ describe('installer tests', () => {
} }
}, 100000); }, 100000);
it('Uses version of node installed in cache', async () => { // Usage of pre-cached Node.js is temporarily disabled.
xit('Uses version of node installed in cache', async () => {
const nodeDir: string = path.join(toolDir, 'node', '250.0.0', os.arch()); const nodeDir: string = path.join(toolDir, 'node', '250.0.0', os.arch());
await io.mkdirP(nodeDir); await io.mkdirP(nodeDir);
fs.writeFileSync(`${nodeDir}.complete`, 'hello'); fs.writeFileSync(`${nodeDir}.complete`, 'hello');
@ -111,7 +112,8 @@ describe('installer tests', () => {
return; return;
}); });
it('Resolves semantic versions of node installed in cache', async () => { // Usage of pre-cached Node.js is temporarily disabled.
xit('Resolves semantic versions of node installed in cache', async () => {
const nodeDir: string = path.join(toolDir, 'node', '252.0.0', os.arch()); const nodeDir: string = path.join(toolDir, 'node', '252.0.0', os.arch());
await io.mkdirP(nodeDir); await io.mkdirP(nodeDir);
fs.writeFileSync(`${nodeDir}.complete`, 'hello'); fs.writeFileSync(`${nodeDir}.complete`, 'hello');

7
dist/index.js vendored
View File

@ -12231,7 +12231,8 @@ function getNode(versionSpec) {
let toolPath; let toolPath;
toolPath = tc.find('node', versionSpec); toolPath = tc.find('node', versionSpec);
// If not found in cache, download // If not found in cache, download
if (!toolPath) { // Usage of pre-cached Node.js is temporarily disabled.
if (true) {
let version; let version;
const c = semver.clean(versionSpec) || ''; const c = semver.clean(versionSpec) || '';
// If explicit version // If explicit version
@ -12248,7 +12249,8 @@ function getNode(versionSpec) {
// check cache // check cache
toolPath = tc.find('node', version); toolPath = tc.find('node', version);
} }
if (!toolPath) { // Usage of pre-cached Node.js is temporarily disabled.
if (true) {
// download, extract, cache // download, extract, cache
toolPath = yield acquireNode(version); toolPath = yield acquireNode(version);
} }
@ -12342,6 +12344,7 @@ function acquireNode(version) {
let downloadUrl = `https://nodejs.org/dist/v${version}/${urlFileName}`; let downloadUrl = `https://nodejs.org/dist/v${version}/${urlFileName}`;
let downloadPath; let downloadPath;
try { try {
core.info(`Downloading ${downloadUrl}`);
downloadPath = yield tc.downloadTool(downloadUrl); downloadPath = yield tc.downloadTool(downloadUrl);
} }
catch (err) { catch (err) {

7
src/installer.ts
View File

@ -25,7 +25,8 @@ export async function getNode(versionSpec: string) {
toolPath = tc.find('node', versionSpec); toolPath = tc.find('node', versionSpec);
// If not found in cache, download // If not found in cache, download
if (!toolPath) { // Usage of pre-cached Node.js is temporarily disabled.
if (true) {
let version: string; let version: string;
const c = semver.clean(versionSpec) || ''; const c = semver.clean(versionSpec) || '';
// If explicit version // If explicit version
@ -45,7 +46,8 @@ export async function getNode(versionSpec: string) {
toolPath = tc.find('node', version); toolPath = tc.find('node', version);
} }
if (!toolPath) { // Usage of pre-cached Node.js is temporarily disabled.
if (true) {
// download, extract, cache // download, extract, cache
toolPath = await acquireNode(version); toolPath = await acquireNode(version);
} }
@ -146,6 +148,7 @@ async function acquireNode(version: string): Promise<string> {
let downloadPath: string; let downloadPath: string;
try { try {
core.info(`Downloading ${downloadUrl}`);
downloadPath = await tc.downloadTool(downloadUrl); downloadPath = await tc.downloadTool(downloadUrl);
} catch (err) { } catch (err) {
if (err instanceof tc.HTTPError && err.httpStatusCode == 404) { if (err instanceof tc.HTTPError && err.httpStatusCode == 404) {